Skip to content

Clean TypeScript outputs for pinned submodule builds - #143

Merged
Eduardo Villalpando Mello (edvilme) merged 3 commits into
mainfrom
build/source-provenance
Nov 18, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 3 commits into
mainfrom
build/source-provenance

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Clean shared TypeScript dist before compiling so deleted sources cannot leave stale JavaScript or declarations.
  • Add one regression to the existing TypeScript suite that runs the real npm build, rejects stale outputs, and checks that the current entrypoint is emitted.
  • Document the pinned-submodule build contract: use the consumer's recorded gitlink, rebuild TypeScript, and install Python from the same checkout before packaging.

The Git submodule pin remains the source identity. Removed the paired-artifact CLI, INPUTS allowlist, snapshots, fingerprints, artifact manifests, Python-wheel orchestration, and their nox hooks. Python/runtime APIs, dependency versions, and lockfiles do not change; nox matches main.

Related to #141. Consumer pipeline enforcement and compatibility tests remain extension-owned.

Validation

  • Node 24.17.0 / npm 11.13.0, matching .nvmrc.
  • The new regression fails with the original tsc-only build because obsolete outputs survive.
  • With cleanup enabled: build passes and all 188 TypeScript tests pass.
  • ESLint, including the new test, passes with two existing production warnings; the new test passes Prettier.
  • git diff --check passes. Existing production TypeScript formatting issues remain unchanged and outside this PR.

Clean TypeScript outputs, build paired runtimes from isolated source snapshots, and validate source identity and complete artifact contents with focused regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Retain source-build tests after localization retirement, align adoption guidance with private source-only metadata, and fix canonical LF/CRLF identity checks across platforms without weakening dirty-source rejection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Top-level artifact directory symlinks can bypass staging isolation, and missing fresh-destination build coverage leaves snapshot copying, build commands, cleanup, and provenance generation untested.

2 open issues
What changed in this PR

Adds paired TypeScript and Python source builds with provenance verification, delivering the generic build portion of #141. Consumer-pipeline adoption remains separate, with no runtime API or dependency-version changes.

Changes:

  • Clean TypeScript outputs before compiling to remove stale artifacts.
  • Build both runtimes from one isolated snapshot and verify the source pin, dirty state, input fingerprint, and artifact hashes.
  • Add regression tests, nox integration, and build/verification documentation.
File Description
typescript/​package.json Clean dist before compilation.
scripts/​source_build.py Add paired build and provenance verification CLI.
scripts/​source_build_test.py Cover source identity and artifact validation.
README.md Document commands, prerequisites, and verification limits.
noxfile.py Integrate source-build tests and script lint checks.
CONTRIBUTING.md Link verified builds and clarify consumer adoption scope.
.gitignore Ignore isolated test-submodules/ staging.

Review effort: Balanced

Comment thread scripts/source_build.py Resolved
Comment thread scripts/source_build.py Resolved
Keep clean TypeScript output, a real stale-output build regression, and concise consumer build guidance. Remove the paired-artifact CLI, input allowlist, fingerprints, wheel orchestration, and their Python automation; preserve existing local consumer-validation staging.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change to prevent stale TypeScript build outputs.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@rchiodo

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown
Contributor

Reviewed commit: d8b3e078a3380fa746ff5924370f16b5022d2977

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "6bb4dc1de70e6c1d76a4c12919758f71845531d966e8f1e19fb6d29b266213da": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 18, 2026
@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 44bf761 into main Nov 18, 2026
20 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the build/source-provenance branch November 18, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code Cleanup, Refactorings and Repo health. Not feature related review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants