Repository navigation
Clean TypeScript outputs for pinned submodule builds - #143
Conversation
Clean TypeScript outputs, build paired runtimes from isolated source snapshots, and validate source identity and complete artifact contents with focused regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
Retain source-build tests after localization retirement, align adoption guidance with private source-only metadata, and fix canonical LF/CRLF identity checks across platforms without weakening dirty-source rejection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
There was a problem hiding this comment.
🟡 Changes recommended
Top-level artifact directory symlinks can bypass staging isolation, and missing fresh-destination build coverage leaves snapshot copying, build commands, cleanup, and provenance generation untested.
2 open issues
What changed in this PR
Adds paired TypeScript and Python source builds with provenance verification, delivering the generic build portion of #141. Consumer-pipeline adoption remains separate, with no runtime API or dependency-version changes.
Changes:
- Clean TypeScript outputs before compiling to remove stale artifacts.
- Build both runtimes from one isolated snapshot and verify the source pin, dirty state, input fingerprint, and artifact hashes.
- Add regression tests, nox integration, and build/verification documentation.
| File | Description |
|---|---|
typescript/package.json |
Clean dist before compilation. |
scripts/source_build.py |
Add paired build and provenance verification CLI. |
scripts/source_build_test.py |
Cover source identity and artifact validation. |
README.md |
Document commands, prerequisites, and verification limits. |
noxfile.py |
Integrate source-build tests and script lint checks. |
CONTRIBUTING.md |
Link verified builds and clarify consumer adoption scope. |
.gitignore |
Ignore isolated test-submodules/ staging. |
Review effort: Balanced
Keep clean TypeScript output, a real stale-output build regression, and concise consumer build guidance. Remove the paired-artifact CLI, input allowlist, fingerprints, wheel orchestration, and their Python automation; preserve existing local consumer-validation staging. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "6bb4dc1de70e6c1d76a4c12919758f71845531d966e8f1e19fb6d29b266213da": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.

Summary
distbefore compiling so deleted sources cannot leave stale JavaScript or declarations.The Git submodule pin remains the source identity. Removed the paired-artifact CLI,
INPUTSallowlist, snapshots, fingerprints, artifact manifests, Python-wheel orchestration, and their nox hooks. Python/runtime APIs, dependency versions, and lockfiles do not change; nox matches main.Related to #141. Consumer pipeline enforcement and compatibility tests remain extension-owned.
Validation
.nvmrc.tsc-only build because obsolete outputs survive.git diff --checkpasses. Existing production TypeScript formatting issues remain unchanged and outside this PR.